bpo-38059: Using sys.exit() over exit() in inspect.py#15666
Merged
Conversation
Constants added by the site module like exit() "should not be used in programs"
brandtbucher
requested changes
Sep 5, 2019
brandtbucher
left a comment
brandtbucher
left a comment
Member
There was a problem hiding this comment.
Thanks, this looks good!
I understand that the change is arguably trivial... but given that this is a code change in a commonly-used module, do you mind creating an issue and NEWS entry for it?
alanyee
changed the title
Member
|
Thanks for the PR! |
Contributor
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 9, 2019
Constants added by the site module like exit() "should not be used in programs" (cherry picked from commit e3c59a7) Co-authored-by: Alan Yee <alanyee@users.noreply.github.com>
|
GH-15783 is a backport of this pull request to the 3.8 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 9, 2019
Constants added by the site module like exit() "should not be used in programs" (cherry picked from commit e3c59a7) Co-authored-by: Alan Yee <alanyee@users.noreply.github.com>
|
GH-15784 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
that referenced
this pull request
Sep 9, 2019
miss-islington
added a commit
that referenced
this pull request
Sep 9, 2019
websurfer5
pushed a commit
to websurfer5/cpython
that referenced
this pull request
Jul 20, 2020
Constants added by the site module like exit() "should not be used in programs"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Constants added by the site module like exit() "should not be used in programs"
https://docs.python.org/3/library/constants.html#exit
https://bugs.python.org/issue38059